On Wed, 25 Oct 2023 17:26:13 GMT, Andrew Haley <[email protected]> wrote:
> On s390x only, HotSpot is built by GCC with -ffunction-sections.
> This means that debug helpers such as ps() and pfl() are not available. These
> helpers are extremely useful in debugging, so it makes no sense to omit them
> from debug builds.
The comment in the block says:
# do this on s390x also for libjvm (where serviceability agent is not
supported)
...which I read as "if we enable this, SA would break". Does
`serviceability/sa` pass in both release and fastdebug with this change?
-------------
PR Review: https://git.openjdk.org/jdk/pull/16365#pullrequestreview-1698009433
