On Wed, 25 Oct 2023 18:26:23 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> The comment in the block says: > > ``` > # do this on s390x also for libjvm (where serviceability agent is not > supported) > ``` > > ...which I read as "if we enable this, SA would break". Does > `serviceability/sa` pass in both release and fastdebug with this change? I read it as meaning "we don't enable the helpers, because without serviceability agent there's no point in having them. Which is very far from the truth. As you might expect, SA tests don't run on s390: TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg/serviceability/sa 0 0 0 0 I don't think they're specificially excluded on s390. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16365#issuecomment-1781452655
