> Looking at why GHA did not catch > [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it > builds hotspot, I realized we do not configure the build with gtest, which > means we skip the build checks for gtest VM. It would be useful to > cross-compile with all tests enabled, even without running them. > > (This would probably make sense to do for JDK native code, but AFAICS it > would require defining a few new make targets). > > Additional testing: > - [ ] GHA
Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Also get gtest ------------- Changes: - all: https://git.openjdk.org/jdk/pull/16652/files - new: https://git.openjdk.org/jdk/pull/16652/files/ca7c5c9f..eb26ddcd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16652&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16652&range=00-01 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/16652.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16652/head:pull/16652 PR: https://git.openjdk.org/jdk/pull/16652
