On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Looking at why GHA did not catch >> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it >> builds hotspot, I realized we do not configure the build with gtest, which >> means we skip the build checks for gtest VM. It would be useful to >> cross-compile with all tests enabled, even without running them. >> >> (This would probably make sense to do for JDK native code, but AFAICS it >> would require defining a few new make targets). >> >> Additional testing: >> - [ ] GHA > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Also get gtest Ah, so you opened a PR to get GHA run automatically. I see. You can run it manually in your own branch. Go to Actions, select **OpenJDK GHA Sanity Checks** on the left, press the "Run workflow" button on the right, and select your branch instead of `master`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16652#issuecomment-1810041905
