On 2023-12-05 12:30, Frederic Thevenet wrote:
Hi,
I would like to propose a small enhancement to the way the VersionInfo
resources[1] embedded into native exes and dlls on Windows are
populated by the JDK build for its native components, and more
specifically, the value for the property called "Company name".
It is currently always the same as that of "vendor-name" but it It
would be really useful to some build scenarios to allow for the
"company name" property embedded in the VersionInfo compiled resources
to be different from the "vendor name" property that is used within
the JVM (e.g. java -version).
So I'd like to propose the addition of a "--with-jdk-rc-company-name"
configure option which can be used to set "Company name" to its own
value, independently of "'vendor-name", in the same fashion as the
existing "--with-jdk-rc-name" can be used to override the values of
"File description" and "Product name".
So this is really a "--with-jdk-rc-vendor-name", since it will use that
value instead of --with-jdk-vendor-name for the RC fields in Windows
binaries?
Would --with-jdk-vendor-name be used for anything at all on Windows in
that case?
/Magnus
If "--with-jdk-rc-company-name" isn't used, then the vendor-name value
is used instead, reproducing the same behavior than without this patch.
[1]
https://learn.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource
Cheers,
--
Frederic Thevenet
Senior Software Engineer - OpenJDK
Red Hat France<https://www.redhat.com>
BAF5 C2D2 0BE0 1715 5EE1 0815 2065 AD47 B326 EB92
