On Tue, 23 Jan 2024 15:07:15 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracking branch 'upstream/master' into
>> 8298405.doclet-markdown-v3
>> - Address review comments
>> - Fix whitespace
>> - Improve handling of embedded inline taglets
>> - Customize support for Markdown headings
>> - JDK-8298405: Support Markdown in Documentation Comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
> line 1553:
>
>> 1551:
>> 1552: /**
>> 1553: * Determine how much indent to remove from markdown comment.
>
> Suggestion:
>
> * Determine how much indent to remove from Markdown comment.
fixed
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
> line 1585:
>
>> 1583: */
>> 1584: UnicodeReader trimMarkdownComment(UnicodeReader line, int
>> indent) {
>> 1585: int pos = line.position();
>
> Unused.
Yes, and the method has no side effects. Removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1472018320
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1472020269
