On Wed, 12 Jun 2024 23:30:11 GMT, Phil Race <p...@openjdk.org> wrote:
> > > How is this check presented to the PR author and Reviewers of a PR? Is it > > > listed as a warning similar to the issue title warning? Do you have a > > > sample PR (Draft is fine) that would show how this looks? > > > > > > [openjdk/playground#208](https://github.com/openjdk/playground/pull/208) > > Here is a sample PR. Maybe we need to rephrase the warning message. > > I agree, the phrasing makes it sound like a hard error, not a warning, how > about > > "Binary files checked into project source repositories are strongly > discouraged, you should consider alternative solutions." > > But why does your example warn on a .png ? They are supposed to be allowed .. The BinaryCheck in SKARA does not differentiate between types of binary files, it warns for all binary files. But it's just a warning, so if the reviewers think it's ok, you can integrate your pr with the warning. > If skara really is unable to distinguish a png from an exe, then I agree the > warning needs to be toned way down to an "FYI", not even a warning. And > something less scary than the yellow triangle with a "!" as the graphic too. I don't think we should remove the warning icon(yellow triangle with a "!"), if so, I bet someone will complain that the warning is not eye-catching enough... ------------- PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2164113364 PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2166711766
