On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race <p...@openjdk.org> wrote:
>> @kevinrushforth said in >> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our >> repositories contain source code and not binary files. There are exceptions >> to this for images and other similar resources, but otherwise the policy for >> most repos is to avoid binary files'. Skara is able to identify binary files >> when executing jcheck, but this check is not enabled. > > If skara really is unable to distinguish a png from an exe, then I agree the > warning needs to be toned way down to an "FYI", not even a warning. > And something less scary than the yellow triangle with a "!" as the graphic > too. @prrace We don't add png files that often, and when we do, I think we can live with a warning sign. But I agree that the text needs to be more clear that this is not necessarily forbidden, but requires an additionl check and confirmation that it is okay in this case. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2167790933
