On Thu, 27 Jun 2024 01:48:23 GMT, Jan Kratochvil <jkratoch...@openjdk.org> wrote:
>> make/autoconf/jdk-options.m4 line 449: >> >>> 447: if test "x$TOOLCHAIN_TYPE" = "xclang"; then >>> 448: ASAN_CFLAGS="$ASAN_CFLAGS >>> -fsanitize-address-use-after-return=never" >>> 449: fi >> >> There's no change being made for the microsoft toolchain. It seems like the >> same issues with the fake stack >> should arise there. > > So I have tried it in AWS and added the [new > comment](https://github.com/openjdk/jdk/pull/19843/commits/08153d9cf2ab8d0721fc1f257f9d662de4814212) > about it as MSVC has it off by default. > [Microsoft > documentation](https://learn.microsoft.com/en-us/cpp/sanitizers/error-stack-use-after-return?view=msvc-170) > even implies it is off by default. > But I have filed [JDK-8335228](https://bugs.openjdk.org/browse/JDK-8335228) > as the MS-Windows OpenJDK build crashes if one explicitly enables > `-fsanitize-address-use-after-return` there. I guess we'll have to monitor this in future VS updates, which might start enabling it. But this seems okay for now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1656755840
