On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt <l...@openjdk.org> wrote:
> On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This action was > implemented as solution of an older bug. > > The solution is incomplete because it does not handle files with read-only > permissions correctly. Without write permission, matter cannot remove the > extended attributes. The action is rejected with a "permission denied" error. > > The issue is present in all releases. I reproduced it in 11, 17, ... 23, head > > The solution is to "chmod u+w" only those files which need to have their > extended attributes removed. > > Backport note: in releases prior to jdk23, the change needs to go into file > MakeBase.gmk. > > Testing @SAP completed without any related issues. If we want to make a file read-only in the build output, it needs to happen explicitly after any copy operation. I think it's fine to leave write permission for the user in this case. The only reason I could imagine this happening is if the source tree (or subsets thereof) has somehow ended up read-only. That seems like a user environment problem, but we shouldn't fail like this because of it. ------------- Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20203#pullrequestreview-2230789150
