On Mon, 26 Aug 2024 21:30:51 GMT, Chris Plummer <[email protected]> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java line 85:
>
>> 83:
>> 84: private static Klass getKlass(Mark mark) {
>> 85: assert(VM.getVM().isCompactObjectHeadersEnabled());
>
> `mark.getKlass()` already does this assert. I don't see any value in this
> `getKlass()` method. The caller should just call `getMark().getKlass()`
> rather than `getKlass(getMark())`.
I'm not sure why this got marked as resolved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1750600652
