On Mon, 21 Oct 2024 06:12:01 GMT, Quan Anh Mai <[email protected]> wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address some changes from code review
>
> src/hotspot/share/opto/compile.cpp line 2464:
>
>> 2462: {
>> 2463: TracePhase tp("lower", &timers[_t_lower]);
>> 2464: print_method(PHASE_BEFORE_LOWERING, 3);
>
> Isn't `BEFORE_LOWERING` the same as `AFTER_BARRIER_EXPANSION` right above?
This is a fair point, I added it originally since macro expansion also printed
before and after but I see now that there is some extra logic that isn't
covered before macro expansion. I think it makes sense to remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21599#discussion_r1814089501
