On Mon, 4 Nov 2024 04:09:47 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Hi all, >> Sometimes some tests only fails or crash run by fastdebug/slowdebug jdk >> binary, such as >> `java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1` which has >> been recorded by [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244). >> To make less CI noisy, we can disable these tests by add tag such as >> `@requires vm.debug == false`, but I think put the releated tests to >> Problemlist is a better way before the root cause failure has been fixed. >> Thus I think it's necessary support Problemlist for fastdebug/slowdebug >> build, the Problemlist only work for fastdebug/slowdebug build. >> By the way, the timeout factor with fastdebug/slowdebug should larger than >> release build, this PR also make jtreg timeoutFactor to 10 if the tested jdk >> is fastdebug/slowdebug build. > > make/RunTests.gmk line 861: > >> 859: ifneq ($$(DEBUG_LEVEL), release) >> 860: JTREG_AUTO_PROBLEM_LISTS += ProblemList-debug.txt >> 861: JTREG_AUTO_TIMEOUT_FACTOR := 10 > > Please don't do this. We set timeout factors as determined by how the tests > will be run in our CI and this could interfere with that. The priority of TIMEOUT_FACTOR set outside is higher than in this makefile. This is set the default value, similar to https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L848 or https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L852 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21862#discussion_r1827229152
