On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing a bug would be surprised if we broke 64-bit Windows with
> this "cleanup" PR. I think the PR like this should only carry the changes
> that are provably, uncontroversially, visibly safe. Everything else that has
> any chance to do semantic changes, should be done in follow-up PRs, IMO.
@shipilev Sure, I can revert the `_stdcall` changes from here and put them in a
a separate PR. Kim also expressed a similar wish.
Removing dead code like this is both a bit of an iterative process ("oh, now
that we removed X, we can also remove Y"), and a bit of a judgement call ("now
that `JNICALL` is not needed,we can remove it"). Sometimes it is not clear
where to draw the line. Personally, I'm mostly interested in getting rid of all
the junk in the build system; all the rest is just stuff I do as a "community
service" to avoid having stuff laying around. (And I did it, under the
(apparently naïve) assumption that this would not require that much extra work
:-), coupled with the (more cynical) assumption that if I did not do this,
nothing would really happen on this front...)
I personally do think that removing the obsolete `_stdcall` is "provably,
uncontroversially, visibly safe". But then again, it's not me who is going to
have to chase the future bugs, so I respect your opinion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2462174907
