On Fri, 8 Nov 2024 18:26:25 GMT, Saint Wesonga <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Inline buildJniFunctionName
>
> src/hotspot/os/posix/include/jvm_md.h line 41:
>
>> 39:
>> 40: #define JNI_ONLOAD_SYMBOLS {"JNI_OnLoad"}
>> 41: #define JNI_ONUNLOAD_SYMBOLS {"JNI_OnUnload"}
>
> are these changes related to the Windows 32-bit x86 port?
After removal of Windows 32-bit x86 port, all definitions of these macros are
identical, so are merged into jvm.h.
There is additional followup work involving these: see
https://bugs.openjdk.org/browse/JDK-8343703.
> src/hotspot/os/posix/os_posix.cpp line 699:
>
>> 697: }
>> 698:
>> 699: void os::print_jni_name_prefix_on(outputStream* st, int args_size) {
>
> are these changes related to the Windows 32-bit x86 port?
As part of removal of Windows 32-bit x86 port, these functions are no longer
needed nor called, and all
definitions removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1834900456
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1834900337
