On Tue, 19 Nov 2024 14:23:30 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Please review this patch to automatically set `TEST_DEPS` to `docs-jdk` when > testing the documentation. > > This comes as a followup to > https://github.com/openjdk/jdk/commit/07f550b85a3910edd28d8761e2adfb8d6a1352f6 > , as review comments suggested better aways of adding dependencies and to > not require users to use a verbose `make test TEST=docs_all > TEST_DEPS=docs-jdk`. > > I have verified that `make test-docs_all` does indeed build the docs, `make > test TEST=docs_all` does not but the former is clear and short enough to be > used. > > TIA. Thanks, will wait until Magnus can take a look. One thing I noticed is that I can't set aliases for `test-docs_all` the same way it's done for the test groups above test-hotspot-gtest: exploded-test-gtest test-jdk-jtreg-native: test-jdk_native_sanity I suspect that's because I've already set aliases once in `AddTestDependency` Trying to use an alias (as in `test-alldocs: test-docs_all`) emits this warning `make: *** No rule to make target 'test-alldocs'. Stop` ------------- PR Comment: https://git.openjdk.org/jdk/pull/22239#issuecomment-2488082823
