On Tue, 19 Nov 2024 14:23:30 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Please review this patch to automatically set `TEST_DEPS` to `docs-jdk` when > testing the documentation. > > This comes as a followup to > https://github.com/openjdk/jdk/commit/07f550b85a3910edd28d8761e2adfb8d6a1352f6 > , as review comments suggested better aways of adding dependencies and to > not require users to use a verbose `make test TEST=docs_all > TEST_DEPS=docs-jdk`. > > I have verified that `make test-docs_all` does indeed build the docs, `make > test TEST=docs_all` does not but the former is clear and short enough to be > used. > > TIA. Looks good. Only targets added to ALL_TARGETS will be exposed from Main.gmk, or rather, known by the Init.gmk bootstrapping make script, so that it can pass it on to Main.gmk when it is subsequently launched. ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22239#pullrequestreview-2462090847 PR Comment: https://git.openjdk.org/jdk/pull/22239#issuecomment-2501354556
