On Thu, 12 Dec 2024 16:19:58 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) >> into this error >> >> >> make all >> Building target 'all' in configuration '/open_jdk/jdk/build_aix' >> Creating 1 test executable file(s) for BUILD_LIBTEST_JTREG_EXECUTABLES >> StaticLibs.gmk:107: *** Unsupported platform. Stop. >> make/Main.gmk:457: recipe for target 'static-launcher' failed >> gmake[2]: *** [static-launcher] Error 1 >> >> >> For now, do not build the static-jdk-image part on AIX. > > make/Main.gmk line 1314: > >> 1312: # all-images builds all our deliverables as images. >> 1313: ifeq ($(call isTargetOs, aix), true) >> 1314: all-images: product-images test-image all-docs-images > > I think you should indent the all-images line like in the other places. Yes please use indentation and avoid repeating code. Suggestion: all-images: product-images test-image all-docs-images ifeq ($(call isTargetOs, aix), false) all-images: static-jdk-image endif ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22713#discussion_r1882648694
