On Thu, 12 Dec 2024 22:46:16 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Yes please use indentation and avoid repeating code. >> Suggestion: >> >> all-images: product-images test-image all-docs-images >> ifeq ($(call isTargetOs, aix), false) >> all-images: static-jdk-image >> endif > > Eriks suggestion is almost okay, but you should filter on the supported > platforms for static images instead, that is, check `ifeq ($(call isTargetOs, > linux macosx), true)` instead. Hi Magnus, what about Windows ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22713#discussion_r1883520621
