On Mon, 16 Dec 2024 16:54:46 GMT, Archie Cobbs <aco...@openjdk.org> wrote:
> Please review this fix for an incorrect `lint:` tag in `compiler.properties`,
> plus an adjustment to the build process to automatically detect and fail the
> build in case of any similar typos in the future.
Thanks for catching this
src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 383:
> 381: * @throws IllegalArgumentException if no such lint category
> exists
> 382: */
> 383: public static LintCategory forOption(String option) {
Maybe we should call this "getOrThrow" ?
test/langtools/tools/javac/lint/LintWarningCategoryTest.java line 36:
> 34: import com.sun.tools.javac.resources.CompilerProperties.LintWarnings;
> 35:
> 36: public class LintWarningCategoryTest {
Do we need this specific test? Or will either the build, or other tests fail in
case there's a lint category/name mismatch?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22769#issuecomment-2546362030
PR Review Comment: https://git.openjdk.org/jdk/pull/22769#discussion_r1887316915
PR Review Comment: https://git.openjdk.org/jdk/pull/22769#discussion_r1887319068
