On Mon, 16 Dec 2024 19:18:25 GMT, Archie Cobbs <[email protected]> wrote:
>> test/langtools/tools/javac/lint/LintWarningCategoryTest.java line 36:
>>
>>> 34: import com.sun.tools.javac.resources.CompilerProperties.LintWarnings;
>>> 35:
>>> 36: public class LintWarningCategoryTest {
>>
>> Do we need this specific test? Or will either the build, or other tests fail
>> in case there's a lint category/name mismatch?
>
> We don't strictly need this test, because build will fail now if any `lint:`
> label is invalid, so the test is redundant.
>
> But I also wasn't sure if it was OK to not have any test at all.
>
> Another option would be to split this change two separate bugs/PRs, but that
> seems like overkill.
>
> (flips through OpenJDK developer guide...) Maybe the best answer would to
> remove the test and add the `noreg-build` label, as this can be considered a
> build fix.
>
> Let's try that route... updated in 3f792a8b650.
yeah, it's ok not to have a test, but you need some keyword, which you added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22769#discussion_r1887380257
