On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > removed jdk.internal package prefix from asm Thanks for doing the right thing and reverting the package name and removing the `@modules` from the tests. I sample as many as I could and they look fine. I assume you'll bump the copyright headers of the modified tests before integrating. Can you say which tiers have been run? I'm sure David can advise but I suspect you'll need to run most of the tiers to ensure that all the modified tests are run. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22946#issuecomment-2581190049