On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > removed jdk.internal package prefix from asm I'm wondering about the build implications of this. This will move ASM from pre-compiled java classes in the JDK, into on-the-fly compiled classes in JTreg. I'm just back from vacation, so I have not had much time to look at this, but it does not seem as simple as "just move the files", and I'd like to get some more consideration about this change before it is pushed. For instance, maybe we could rely on upstream ASM for the tests? I assume it gets distributed as a jar, that we could add as a dependency. (I guess that removing the `jdk.internal` prefix from the package name would be a pre-requisite for such a change, so that might also give the suggestion to this some more weight.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/22946#issuecomment-2582643101
