On Mon, 13 Jan 2025 03:02:27 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> Next version of Capstone (6.0.0-Alpha1 at least) would locate the library > into `lib64` directory rather than `lib` on 64bit Linux due to following PR. > https://github.com/capstone-engine/capstone/pull/2214 > > Thus hsdis build should follow this change for the future. make/autoconf/lib-hsdis.m4 line 43: > 41: if test "x$OPENJDK_TARGET_OS" != xwindows; then > 42: HSDIS_LDFLAGS="-L${CAPSTONE}/lib" > 43: if test $OPENJDK_TARGET_CPU_BITS -eq 64; then Please follow our pattern for writing if statements: Suggestion: if test "x$OPENJDK_TARGET_CPU_BITS" = "x64" ; then ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23059#discussion_r1913090324
