On Mon, 13 Jan 2025 12:09:16 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update make/autoconf/lib-hsdis.m4
>>
>> Co-authored-by: Magnus Ihse Bursie <m...@icus.se>
>
> make/autoconf/lib-hsdis.m4 line 43:
>
>> 41: if test "x$OPENJDK_TARGET_OS" != xwindows; then
>> 42: HSDIS_LDFLAGS="-L${CAPSTONE}/lib"
>> 43: if test $OPENJDK_TARGET_CPU_BITS -eq 64; then
>
> Please follow our pattern for writing if statements:
>
> Suggestion:
>
> if test "x$OPENJDK_TARGET_CPU_BITS" = "x64" ; then
Thanks for the comment! I applied your suggestion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23059#discussion_r1913152666
