On Tue, 21 Jan 2025 16:34:17 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> test/make/TestIdea.gmk line 32: >> >>> 30: >>> 31: # Enable the shell script to call make without us interfering. >>> 32: # We will keep the $(SPEC), though, to find back to our configuration. >> >> This comment confuses me. Why do we need to keep `SPEC` defined? > > This is so that when `idea.sh` finally calls make again, we will get back to > our configuration. Otherwise, if we have multiple configurations, `idea.sh` > will fail since it can't single out a specific one. This will not show up on > CI runs where we only have a single configuration, but can arise when running > the test locally with several configurations. I thought that was about what I said in the comment, and I feel like I mostly repeat myself. Can you suggest a better way to phrase it, if it is still not clear enough? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23200#discussion_r1924044418
