On Thu, 30 Jan 2025 14:51:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> The Init.gmk (and, correspondingly, InitSupport.gmk) is really two files in >> one: First it is called without $(SPEC), and does the work needed to locate >> a SPEC (and sanity check arguments), and then it calls itself again with a >> SPEC value. >> >> This is two completely different tasks, and there is no reason it should be >> put in the same file. It just makes the file longer and harder to read and >> understand. >> >> This work is done as a preparation for fixing >> https://bugs.openjdk.org/browse/JDK-8292944. The code was just to hard to >> follow to be able to fix it without going insane. >> >> Also, GitHub is spectacularly bad at showing the diff for this patch! I >> think it might be easier to review if you do it commit by commit, or >> possibly using the webrev frame view. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Even more missing include paths Apologies for the force push; I deleted two commits that I mistakenly pushed to this branch where they did not belong. (I'm juggling a bit too many branches currently for the sake of my sanity...) ------------- PR Comment: https://git.openjdk.org/jdk/pull/23355#issuecomment-2624737771
