On Wed, 29 Jan 2025 19:56:17 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> The Init.gmk (and, correspondingly, InitSupport.gmk) is really two files in > one: First it is called without $(SPEC), and does the work needed to locate a > SPEC (and sanity check arguments), and then it calls itself again with a SPEC > value. > > This is two completely different tasks, and there is no reason it should be > put in the same file. It just makes the file longer and harder to read and > understand. > > This work is done as a preparation for fixing > https://bugs.openjdk.org/browse/JDK-8292944. The code was just to hard to > follow to be able to fix it without going insane. > > Also, GitHub is spectacularly bad at showing the diff for this patch! I think > it might be easier to review if you do it commit by commit, or possibly using > the webrev frame view. This pull request has now been integrated. Changeset: 5878e45a Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/5878e45ae07404bc18518e6a2cb551a7969fddd6 Stats: 1488 lines in 7 files changed: 692 ins; 621 del; 175 mod 8348998: Split out PreInit.gmk from Init.gmk Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/23355
