On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> The HotSpot Style Guide has a section about source files and includes. The >> style used for includes have mostly been introduced by scripts when >> includeDB was replaced, but also when various other enhancements to our >> includes were made. Some of the introduced styles were never written down in >> the style guide. >> >> I propose a couple of changes to the HotSpot Style Guide to reflect some of >> these implicit styles that we have. While updating the text I also took the >> liberty to order the items in an order that I felt was good. >> >> Note that JDK-8323158 contains a few more suggestions, but I've only >> addressed the items that I think can be accepted without much contention. >> Either I extract the items that have not been address into a new RFE, or I >> create a new RFE for this PR. >> >> There a some small whitespace tweaks that I made so that the .md and .html >> had a similar layout. > > Stefan Karlsson has updated the pull request incrementally with two > additional commits since the last revision: > > - Update hotspot-style.md > - Update hotspot-style.html Generally seems fine. Thanks. doc/hotspot-style.html line 213: > 211: <li><p>Put conditional inclusions (`#if ...`) at the end of the section > of HotSpot > 212: include lines. This also applies to macro-expanded includes of platform > 213: dependent files.</p></li> What is the order for the conditional sections? Alphabetic on the include guard? ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23388#pullrequestreview-2594441092 PR Review Comment: https://git.openjdk.org/jdk/pull/23388#discussion_r1942135021
