On Wed, 5 Feb 2025 01:42:36 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update hotspot-style.md >> - Update hotspot-style.html > > doc/hotspot-style.html line 213: > >> 211: <li><p>Put conditional inclusions (`#if ...`) at the end of the section >> of HotSpot >> 212: include lines. This also applies to macro-expanded includes of platform >> 213: dependent files.</p></li> > > What is the order for the conditional sections? Alphabetic on the include > guard? I don't think there's a set order. I wouldn't mind making it alphabetic with platforms includes coming before the other conditional includes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23388#discussion_r1942464083
