On Wed, 5 Feb 2025 03:35:51 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> I think bytecodeInterpreterWithChecks was removed a long time ago. It is >> still referenced in 8u-dev: >> https://github.com/openjdk/jdk8u-dev/blob/master/hotspot/src/share/vm/interpreter/bytecodeInterpreterWithChecks.xml >> I guess that both interpreter excludes could be removed from >> `JVM_PRECOMPILED_HEADER_EXCLUDE`. @coleenp may know more. > > As I reported in JBS, `bytecodeInterpreterWithChecks.cpp` was a generated > file for use with JVMTI. There was no indication as to why `bytecodeInterpreter.cpp` was made no-PCH back in [JDK-6571248](https://bugs.openjdk.org/browse/JDK-6571248), and it appears to only have been for Windows. So removing it now seems reasonable, though we should be able to verify that the object file remains the same regardless, just to be safe. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23442#discussion_r1942217621
