On Wed, 5 Feb 2025 06:35:43 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> There was no indication as to why `bytecodeInterpreter.cpp` was made no-PCH >> back in [JDK-6571248](https://bugs.openjdk.org/browse/JDK-6571248), and it >> appears to only have been for Windows. So removing it now seems reasonable, >> though we should be able to verify that the object file remains the same >> regardless, just to be safe. > > I don't think that is possible, you cannot compile a Zero VM on Windows, so > it will not be possible to tell whether the object file on Windows has > changed or not. I do have a Windows/Zero port downstream, but haven't gotten > around to fixing it on top of latest JDK yet > > Is bytecodeInterpreterWithChecks.cpp still used by JVMTI now? bytecodeInterpreterWithChecks.cpp was removed some time ago. If no one can even build Windows Zero today then we are not going to make anything worse ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23442#discussion_r1944226646
