On Fri, 28 Feb 2025 00:37:24 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> A simple fix in `os::jvm_path()` so that gtest can be run with CDS >> (`-Xshare:on`). The fix is just to change the directory name from `hotspot` >> to `server`. >> Note that the bug doesn't exist on macOS and thus no change is required for >> `os_bsd.cpp`. >> >> Testing: >> >> - run gtest with -Xshare:on on linux-x64 >> - tier1 > > Calvin Cheung has updated the pull request incrementally with one additional > commit since the last revision: > > @magius and @iklam comments I like this approach as it addresses the real issue - that we need to know the variant name to find the right directory. The jvm_path logic in os_bsd is completely broken so we should look at cleaning that up separately. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23758#pullrequestreview-2649521617
