On Thu, 6 Mar 2025 16:38:13 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> make/autoconf/platform.m4 line 669: >> >>> 667: AC_ARG_ENABLE(deprecated-ports, >>> [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], >>> 668: [Suppress the error when configuring for a deprecated port >>> @<:@no@:>@])]) >>> 669: # There are no deprecated ports. This option is left to be >>> consistent with future deprecations. >> >> Please remove. Old code is always present in git history if you want to >> reuse it. > > I don't mind removing it, my concern would be to _remember_ this option was > there! I guess it is okay to re-re-invent it later, possibly under a > different name, when the next port gets deprecated. It's no that important, no. I'm not sure if previous deprecated ports were handles exactly like this. And you can always do like `git log | grep -i "remove .* port"` to find the change it was removed in, and look what it did... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23906#discussion_r1983855800
