On Mon, 10 Mar 2025 09:46:38 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> The `--enable-deprecated-ports` is still there. All that is removed is an if
>> statement and a print line. I know the make syntax can seem intimidating,
>> but just ask me or any other build team member if you need help to recreate
>> such a thing. It is not like it is a complicated algorithm that can be
>> written in many ways. This is just make's equivalant of:
>>
>>
>> if (some_condition) {
>> println("whatever");
>> }
>>
>>
>> To me this is just utter nonsense to keep that commented out.
>
> "Utter nonsense" might be a bit harsh. We do code samples around OpenJDK all
> the time to leave breadcrumbs for future use. As I said, I don't mind
> removing it, done so in new commit.
Yes, you are right. That did not sound good. I apologize. (And thanks for
removing it!)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23906#discussion_r1987327814
