On Fri, 21 Mar 2025 10:33:10 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added needed include
>
> make/StaticLibs.gmk line 117:
>
>> 115: OUTPUT_FILE := $(lib).exp, \
>> 116: COMMAND := ( $(AR) $(ARFLAGS) -w $(lib) | $(GREP) -v '^\.' |
>> $(AWK) '{print $$1}' | $(SORT) -u > $(lib).exp ), \
>> 117: )) \
>
> To better align with how we store the targets of Setup calls, can you please
> change this to:
>
> Suggestion:
>
> STATIC_LIBS := -Wl,-bexpfull $(STATIC_LIB_FILES) $(addprefix
> -Wl$(COMMA)-bE:, $(STATIC_LIB_EXPORT_FILES))
> $(foreach lib, $(STATIC_LIB_FILES), \
> $(eval $(call SetupExecute, generate_export_list_$(notdir $(lib)), \
> INFO := Generating export list for $(notdir $(lib)), \
> DEPS := $(lib), \
> OUTPUT_FILE := $(lib).exp, \
> COMMAND := ( $(AR) $(ARFLAGS) -w $(lib) | $(GREP) -v '^.' | $(AWK)
> '{print $$1}' | $(SORT) -u > $(lib).exp ), \
> )) \
> $(eval STATIC_LIB_EXPORT_FILES += $(lib).exp) \
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24062#discussion_r2007406147
