On Wed, 16 Apr 2025 10:40:49 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> make/autoconf/jdk-options.m4 line 526: >> >>> 524: UBSAN_LDFLAGS="$UBSAN_CHECKS" >>> 525: if test "x$TOOLCHAIN_TYPE" = "xclang" && test "x$OPENJDK_TARGET_OS" >>> = "xaix"; then >>> 526: UBSAN_CFLAGS="$UBSAN_CFLAGS -fno-sanitize=function,vptr >>> -DLLVM_SYMBOLIZER=$(dirname $(dirname $CC))/tools/ibm-llvm-symbolizer" >> >> I would recommend handling this tool path properly, by first trying to look >> it up with one of the standard macros and then falling back to a default, >> and let configure fail if it wasn't found. This would also implicitly add >> the ability for the user to specify a different path if ever needed (using >> VAR_NAME=/path/to/tool on the command line). However, since this isn't a >> platform I'm supporting, I won't force you. > > Can you please give me an example to try? If the tool is (in case it is available) always at THIS position then it is not needed to add more logic. On the other hand, what happens if it is not there ? Would we get just less complete stacks in case of ubsan issues? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24667#discussion_r2048549963
