On Thu, 17 Apr 2025 15:42:09 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> With the introduction of the open XL 17.1.2.13 Compiler and the runtime >> 17.1.3 as minimum requirement ubsan is supported for AIX now. >> Unfortunately there has to be some adoptions. >> - Currently the test for vptr does not work and produces crashes when >> active, so we have to deactivate it. (If fixed by IBM there will be a follow >> up JBS) >> - ubsan introduces so much new symbols to every executable that we have to >> link with -bbictoc. >> - The llvm_symbolizer is not found out of the box, so we have to provide the >> full qualified llvm_symbolizer path in the __ubsan_default_options() >> function. > > Joachim Kern has updated the pull request incrementally with one additional > commit since the last revision: > > adding comments When doing a ubsan enabled build on AIX I also noticed the following warning: unknown warning option '-Wno-stringop-truncation'; did you mean '-Wno-string-concatenation'? [-Wunknown-warning-option] warning: unknown warning option '-Wno-format-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option] warning: unknown warning option '-Wno-stringop-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option] 3 warnings generated. warning: unknown warning option '-Wno-stringop-truncation'; did you mean '-Wno-string-concatenation'? [-Wunknown-warning-option] warning: unknown warning option '-Wno-format-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option] warning: unknown warning option '-Wno-stringop-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option] 3 warnings generated. Seems a couple of warning related flags that are set when running an ubsan enabled build do not exist on AIX (or generally with clang ?). Maybe we should address/adjust this too. See line 523 in jdk-options.m4 just above your patch; probably those options came from gcc ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24667#issuecomment-2829697197
