On Tue, 22 Apr 2025 17:01:20 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add sanity test for AOTAdapterCaching flag
>
> src/hotspot/share/cds/cdsConfig.cpp line 869:
>
>> 867:
>> 868: bool CDSConfig::is_dumping_aot_code_enabled() {
>> 869: return _is_dumping_aot_code_enabled;
>
> Other functions in CDSConfig don't have the `_enabled()` suffix. E.g.,
> `is_dumping_method_handles()`. It doesn't mean we are doing method handle
> right now, but rather we have the ability to do so.
>
> Since we rarely ask "am I in the middle of dumping X right now", I think
> adding `_enabled()` will be redundant.
Okay.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2054541461
