On Thu, 24 Apr 2025 01:39:33 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2966:
>
>> 2964: adapter_blob =
>> AdapterHandlerLibrary::link_aot_adapter_handler(this);
>> 2965: if (adapter_blob == nullptr) {
>> 2966: log_warning(cds)("Failed to link AdapterHandlerEntry (fp=%s) to
>> its code in the AOT code cache", _fingerprint->as_basic_args_string());
>
> Doesn't it add noise in the output for not yet seen adapter shapes? It's a
> warning.
`AdapterHandlerEntry::link` method gets called only for the archived adapters.
Not yet seen adapters do not come across this code path. Reason for making it a
warning is the assumption that, if the AOT Code Cache is usable, then we should
always be able to link the `AdapterHandlerEntry` to its code in the AOT code
cache. If we fail to do so, then something is not right in this machinery and
likely pointing to a bug.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2059204247
