On Sun, 20 Apr 2025 04:01:31 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into make-doctor-on-ci >> - 8345874: Run make doctor automatically on failed CI builds > > make/autoconf/spec.gmk.template line 173: > >> 171: >> 172: # dev or ci >> 173: BUILD_ENV := @BUILD_ENV@ > > I think the `BUILD_ENV` could be seted in command line also. So, should we > update the doc/building.md sync with this change. What do you mean? This is controlled by the `--with-build-env=[ci|dev]` option. It just needed to be exported from the configure script to the make files. I am not sure if `--with-build-env` is documented in building.md, but in any case we just list a short selection of options there; the documentation points to `configure --help` to list all currently available options. (It is not feasible to keep the documentation in sync for every possible option.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24485#discussion_r2063304652
