On Mon, 28 Apr 2025 09:41:38 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> make/autoconf/spec.gmk.template line 173:
>> 
>>> 171: 
>>> 172: # dev or ci
>>> 173: BUILD_ENV := @BUILD_ENV@
>> 
>> I think the `BUILD_ENV` could be seted in command line also. So, should we 
>> update the doc/building.md sync with this change.
>
> What do you mean? This is controlled by the `--with-build-env=[ci|dev]` 
> option. It just needed to be exported from the configure script to the make 
> files.
> 
> I am not sure if `--with-build-env` is documented in building.md, but in any 
> case we just list a short selection of options there; the documentation 
> points to `configure --help` to list all currently available options. (It is 
> not feasible to keep the documentation in sync for every possible option.)

At first I mistakenly thought that the value of the BUILD_ENV variable was read 
from the environment variable

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24485#discussion_r2063564104

Reply via email to