On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Also document UTF-8 requirements (solves JDK-8338973) >> - Let configure only accept utf-8 locales >> - Address review comments from Kim > > make/autoconf/basic.m4 line 155: > >> 153: else >> 154: AC_MSG_RESULT([no UTF-8 locale found]) >> 155: AC_MSG_ERROR([No UTF-8 locale found. This is required for >> building successfully.]) > > Seems we run into this 'else' part on AIX > > > checking for locale to use... no UTF-8 locale found > configure: error: No UTF-8 locale found. This is required for building > successfully. > configure exiting with result code 1 > > maybe it would be nice to display the desired ones C.UTF-8 or en_US.UTF-8 in > this message too for more clarity? (have to check if there are other names > on AIX) > @MBaesken I added an informative text about supported locales. I also lowered > the fatal error of missing an UTF-8 locale into just a warning (for all > platforms, not just AIX). Apparently it works with building on AIX for now, > even with a undefined character encoding, but I will not guarantee that it > will continue to work for all eternity. But a warning is probably be enough, > and if it does work the user is free to try. :) Sounds good to me , thanks for adjusting ! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24574#discussion_r2076970234
