On Tue, 15 Jul 2025 09:58:02 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
> `open/doc/building.md` uses the incorrect `OEL6` keyword to denote the Oracle > Enterprise Linux base OS distribution for Devkit – replaced it with the > correct one instead, i.e., `OL`. You also need to regenerate the corresponding building.html using the `update-build-docs` make target doc/building.md line 1289: > 1287: > 1288: `BASE_OS` must be one of `OL` for Oracle Enterprise Linux or `Fedora` > (if > 1289: not specified `OL` will be the default). If the base OS is `Fedora` the Ever so slightly unrelated to your change, but perhaps worth fixing at the same time, even if it means widening the scope of the issue a bit: There is no default, so suggest dropping the parenthesis part. doc/building.md line 1291: > 1289: not specified `OL` will be the default). If the base OS is `Fedora` the > 1290: corresponding Fedora release can be specified with the help of the > 1291: `BASE_OS_VERSION` option (with `27` as default version). If the build is Also unrelated but maybe worth fixing: the default Fedora version is 41 nowadays. ------------- PR Review: https://git.openjdk.org/jdk/pull/26311#pullrequestreview-3021243737 PR Review Comment: https://git.openjdk.org/jdk/pull/26311#discussion_r2208015960 PR Review Comment: https://git.openjdk.org/jdk/pull/26311#discussion_r2208016509
