On Tue, 15 Jul 2025 16:46:24 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review feedback > > doc/building.md line 1289: > >> 1287: >> 1288: `BASE_OS` must be one of `OL` for Oracle Enterprise Linux or `Fedora` >> (if >> 1289: not specified `OL` will be the default). If the base OS is `Fedora` the > > Ever so slightly unrelated to your change, but perhaps worth fixing at the > same time, even if it means widening the scope of the issue a bit: > > There is no default, so suggest dropping the parenthesis part. Removed in 0d85899ae1a. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26311#discussion_r2208283263
