On Fri, 8 Aug 2025 03:07:58 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> script. update
>
> src/utils/PrecompiledHeaders/PrecompiledHeaders.java line 73:
>
>> 71: paths.filter(Files::isRegularFile)
>> 72: .filter(path -> {
>> 73: String name = path.getFileName().toString();
>
> IIUC this means that we count the number of cpp or hpp files that directly
> include a file, but should we count the number of cpp file that directly or
> transitively include a file instead?
That would be a much more sensitive number indeed. I'll look into the solution
proposed below by @kimbarrett.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2262278283
