On Fri, 8 Aug 2025 12:42:40 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> Note that precompiled.hpp has an include count of 2456. There's 1 .d file that
depends on everything - BUILD_LIBJVM.d. That probably ought to be excluded
from counting, although I guess it should just add one to every file.
Apparently `BUILD_LIBJVM.d` mentions all files multiple times:
% grep "utilities/waitBarrier.hpp"
build/clang/hotspot/variant-server/libjvm/objs/BUILD_LIBJVM.d | wc -l
1231
It's definitely reasonable to exclude it, I did it in the latest revision of
the script.
Now, the numbers seem more reasonable:
% ls build/clang/hotspot/variant-server/libjvm/objs/*.d | grep -v BUILD | wc -l
1232
% grep "code/codeCache.hpp" build/clang/hotspot/variant-server/libjvm/objs/*.d
| \
grep -v BUILD | sort | uniq | wc -l
1230
% grep "code/codeCache.hpp" inclusions_count.txt
code/codeCache.hpp=1230
Updated
[inclusions_count.txt](https://github.com/user-attachments/files/21685761/inclusions_count.txt)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2263090433
