On Fri, 1 Aug 2025 14:33:43 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove problemlisting > > make/ModuleWrapper.gmk line 82: > >> 80: TARGETS += $(LAUNCHERS_LIST) >> 81: endif >> 82: endif > > I think it would be cleaner if this could be kept in LauncherCommon.gmk and > avoid having ModuleWrapper.gmk involved in this. I think it can be done > relatively easily. In SetupBuildLauncherBody, instead of constructing the > variable `$(MODULE)_INCLUDED_LAUNCHERS`, declare dependencies for > `$(LAUNCHER_LIST)`, something like this: > > $(LAUNCHER_LIST): $$($1) > TARGETS += $(LAUNCHER_LIST) > > > Then put the the recipe for `$(LAUNCHER_LIST)` at the end of > LauncherCommon.gmk. The $(LAUNCHER_LIST) value will sometimes be added to > TARGETS multiple times, but that's ok I think. Hm. I put it there since it was the only place where we could be sure we know *all* launchers for a module. I could have each launcher add itself to the list, but then I either need to check if it is already there, or we will just append to the list each time we rebuild. And we risk a race when several launchers build at the same time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2266920768
