On Mon, 11 Aug 2025 17:20:30 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> This solution was modeled on how we create `module-included-libs.txt`. I >> agree that it is a bit hacky to inject this kind of stuff in ModuleWrapper, >> but I can't see how we can do it more cleanly. That's the only point at >> which we know the entire module for a phase. >> >> Maybe we can improve optics by doing a more official-looking "hook" for >> injecting functionality at pre-/post- whole-module processing? That would >> keep ModuleWrapper slimmer and without all the current specialized hooks, >> and make the name "wrapper" more relevant. >> >> Or, we could rename the makefile to indicate better that it does a lot more >> than just wraps a file. (I have no good suggestions right now.) > > I'm not sure what you mean here. I described a solution that keeps it in > LauncherCommon without creating races. Aha, now I understand what you mean! My mind slipped -- I read `LauncherCommon.gmk` but thought `SetupBuildLauncher`. But you mean just store it in the top-level of the actual makefile that is included by all launchers. Yeah, that could definitely work. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2276155249
