On Fri, 15 Aug 2025 15:43:45 GMT, Saint Wesonga <d...@openjdk.org> wrote:
>> make/common/native/CompileFile.gmk line 239: >> >>> 237: $$(call ExecuteWithLog, $$@, $$(call MakeCommandRelative, \ >>> 238: $$($1_COMPILER) $$($1_FLAGS) \ >>> 239: $(CC_OUT_OPTION)$$($1_OBJ) $$($1_SRC_FILE))) \ >> >> Have you verified that removing `-Ta` works for the x86 assembler? > >> Have you verified that removing `-Ta` works for the x86 assembler? > > Yes, both of these command lines work: > > > ; "C:\Program Files\Microsoft Visual > Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\Hostx64\x86\ml.exe" > -nologo -c -Fo test_x86_assembler.obj -Ta test_x86_assembler.S > ; "C:\Program Files\Microsoft Visual > Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\Hostx64\x86\ml.exe" > -nologo -c -Fo test_x86_assembler.obj test_x86_assembler.S > > TEST_SEG SEGMENT > > mov eax, ecx > > TEST_SEG ENDS > > END I wonder why we still have the assembler for 32 bit, as the JDK no longer supports 32 bit Windows ever since Magnus nuked it from the codebase ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26791#discussion_r2279458499
